[PATCH] D146492: Add new printNumber() for size_t

Tue Mar 21 17:59:06 PDT 2023

junhee-yoo added a comment.

In D146492#4210239 <https://reviews.llvm.org/D146492#4210239>, @paulkirth wrote:

> @junhee-yoo can you try https://reviews.llvm.org/D146544? I think that may be a good solution here, so long as @jhenderson agrees it won't run into problems w/ overflow.

I'd checked your change and I think it will work for `ELFDumper.cc` but in my humble opinion, calling `printNumber()` with `size_t` still have a potential problem who doesn't know about.

By the way, @paulkirth if you mind, would you tell me your Mac build env and command to me for reproducing success build? If this problem can be solved by build config, Maybe the proper way to solve this is changing build configs rather than changing the code.

In D146492#4208618 <https://reviews.llvm.org/D146492#4208618>, @paulkirth wrote:

> Hi, sorry this is causing you a problem. I'm surprised our builders haven't picked this up. I'm also unable to reproduce this locally on a Mac or Linux machine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146492/new/

https://reviews.llvm.org/D146492