[PATCH] D145836: [MemProf] Context disambiguation cloning pass [patch 1b/3]

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 15:22:02 PDT 2023


tejohnson added a comment.

In D145836#4211036 <https://reviews.llvm.org/D145836#4211036>, @snehasish wrote:

> lgtm, I assume you will reduce these test cases too?

Thank, yep. My plan is to commit 1a probably tomorrow morning, then rebase this one (applying similar fixes to the comments from 1a where appropriate). Then after I commit 1b I will rebase patch 2 (I'll let you know when that one is ready for re-review).



================
Comment at: llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp:1379
+  if (ExportToDot)
+    exportToDot("prestackupdate");
+
----------------
snehasish wrote:
> Should we give the ThinLTO version a different filename?
good idea will do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145836/new/

https://reviews.llvm.org/D145836



More information about the llvm-commits mailing list