[PATCH] D146568: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 21 15:20:17 PDT 2023
dschuff added a comment.
In D146568#4211390 <https://reviews.llvm.org/D146568#4211390>, @aheejin wrote:
> I'm on the fence too. Are we going to (eventually) change all tests expectations? I think there are tests that can really benefit from the brevity (especially tests added with bugfixes, with which we only want to check a specific few lines of the output). But this test may not be one of them.
That's a good point; these tests are quite short and very targeted IR (as opposed to tests that require complex situations to manifest bugs).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146568/new/
https://reviews.llvm.org/D146568
More information about the llvm-commits
mailing list