[PATCH] D146568: [NFC][WebAssembly] Autogenerate test expectations for tailcall.ll
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 21 14:59:19 PDT 2023
dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.
LGTM I guess. TBH I'm still a little on the fence about whether it's better to have fully auto-generated test expectations which are easy to update but check all the output, or more precisely targeted expectations which are more self-documenting (since they don't include output not relevant to the test at hand) and are less likely to require updating for unrelated changes...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146568/new/
https://reviews.llvm.org/D146568
More information about the llvm-commits
mailing list