[PATCH] D146260: Make code size metric names independent of platform

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: litsupport/modules/codesize.py:42
                     logging.info("Ignoring malformed output line: %s", line)
 
     return metrics
----------------
azharudd wrote:
> I was just thinking maybe, as a good measure, we can assert here that only one of `size.__text` or `size..text` is present in `metrics`.
> 
> ```
> assert not ('size.__text' in metrics and 'size..text' in metrics), "Both 'size.__text' and 'size..text' present in metrics. Only one of them should exist."
> ```
Sure, that sounds like a good idea. Lemme spin up another patch.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146260/new/

https://reviews.llvm.org/D146260