[PATCH] D85540: [llvm-libtool-darwin] Add support for -l and -L

Tue Mar 21 11:29:06 PDT 2023

jrtc27 added inline comments.

================
Comment at: llvm/test/tools/llvm-libtool-darwin/L-and-l.test:95-98
+## Check that an error is thrown when the input library cannot be found
+## (for a file prepended with 'lib' and appended with '.a'):
+# RUN: not llvm-libtool-darwin -static -o %t.lib -lfile-will-not-exist 2>&1 | \
+# RUN:   FileCheck %s --check-prefix=NOT-FOUND -DFILE=libfile-will-not-exist.a
----------------
smeenai wrote:
> jrtc27 wrote:
> > sameerarora101 wrote:
> > > jhenderson wrote:
> > > > One more test for this area: a file called something like `file`, and show that `-lfile` doesn't find it (since `lib` and `.a` are added). Relatedly, maybe also show that `-llibfile.a` looks for `liblibfile.a` not `libfile.a`?
> > > Added now, thanks.
> > This doesn't work if you do have a libfile.a, which is a real library that exists; on FreeBSD it comes as part of schilybase, and so having that package installed breaks this test.
> Heh, fixed in rG22b5fe74782a
Great, thanks for the quick follow-up

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85540/new/

https://reviews.llvm.org/D85540