[llvm] c819257 - [llvm][support] Fix ScopedPrinterTest on AIX
Paul Kirth via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 21 10:36:29 PDT 2023
Author: Paul Kirth
Date: 2023-03-21T17:36:20Z
New Revision: c819257b7f3e88cbb90cdaaa90eec650513702c7
URL: https://github.com/llvm/llvm-project/commit/c819257b7f3e88cbb90cdaaa90eec650513702c7
DIFF: https://github.com/llvm/llvm-project/commit/c819257b7f3e88cbb90cdaaa90eec650513702c7.diff
LOG: [llvm][support] Fix ScopedPrinterTest on AIX
The test strings we used for infinity and NAN were not correct on AIX.
This patch creates those dynamically instead of hard-coded.
Reviewed By: abhina.sreeskantharajan
Differential Revision: https://reviews.llvm.org/D146542
Added:
Modified:
llvm/unittests/Support/ScopedPrinterTest.cpp
Removed:
################################################################################
diff --git a/llvm/unittests/Support/ScopedPrinterTest.cpp b/llvm/unittests/Support/ScopedPrinterTest.cpp
index ea024ec05df6b..f62d310f25d95 100644
--- a/llvm/unittests/Support/ScopedPrinterTest.cpp
+++ b/llvm/unittests/Support/ScopedPrinterTest.cpp
@@ -8,6 +8,7 @@
#include "llvm/Support/ScopedPrinter.h"
#include "llvm/ADT/APSInt.h"
+#include "llvm/Support/Format.h"
#include "gtest/gtest.h"
#include <cmath>
#include <vector>
@@ -594,6 +595,19 @@ TEST_F(ScopedPrinterTest, PrintNumber) {
format("%5.1f", std::numeric_limits<double>::max()).snprint(Buf, sizeof(Buf));
std::string MaxDoubleStr(Buf);
+ format("%5.1f", std::numeric_limits<double>::infinity())
+ .snprint(Buf, sizeof(Buf));
+ std::string InfFloatStr(Buf);
+
+ std::to_string(std::numeric_limits<float>::infinity());
+ std::string InfDoubleStr(Buf);
+
+ format("%5.1f", std::nanf("1")).snprint(Buf, sizeof(Buf));
+ std::string NaNFloatStr(Buf);
+
+ format("%5.1f", std::nan("1")).snprint(Buf, sizeof(Buf));
+ std::string NaNDoubleStr(Buf);
+
std::string ExpectedOut = Twine(
R"(uint64_t-max: 18446744073709551615
uint64_t-min: 0
@@ -615,15 +629,15 @@ apsint: 9999999999999999999999
label: value (0)
float-max: )" + MaxFloatStr + R"(
float-min: 0.0
-float-inf: inf
-float-nan: nan
+float-inf: )" + InfFloatStr + R"(
+float-nan: )" + NaNFloatStr + R"(
float-42.0: 42.0
float-42.5625: 42.6
double-max: )" + MaxDoubleStr +
R"(
double-min: 0.0
-double-inf: inf
-double-nan: nan
+double-inf: )" + InfDoubleStr + R"(
+double-nan: )" + NaNDoubleStr + R"(
double-42.0: 42.0
double-42.5625: 42.6
)")
More information about the llvm-commits
mailing list