[PATCH] D146542: [llvm][support] Fix ScopedPrinterTest on AIX

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 10:16:56 PDT 2023


paulkirth marked an inline comment as done.
paulkirth added inline comments.


================
Comment at: llvm/unittests/Support/ScopedPrinterTest.cpp:598
 
+  format("%5.1f", std::numeric_limits<double>::infinity()).snprint(Buf, sizeof(Buf));
+  std::string InfFloatStr(Buf);
----------------
jhenderson wrote:
> Dumb question maybe, but why the "5.1"?
`"%5.1"` is the format string we use in `printNumber()`. IIRC that was what was taken from existing code in ElfDumper.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146542/new/

https://reviews.llvm.org/D146542



More information about the llvm-commits mailing list