[PATCH] D146539: [DebugInfo] Correct out-of-bounds error message for DW_FORM_line_strp

[Benjamin Maxwell via Phabricator via llvm-commits]

benmxwl-arm created this revision.
Herald added subscribers: cmtice, hiraditya.
Herald added a reviewer: jhenderson.
Herald added a project: All.
benmxwl-arm requested review of this revision.
Herald added subscribers: llvm-commits, jplehr, sstefan1, MaskRay.
Herald added a reviewer: jdoerfert.
Herald added a project: LLVM.

DW_FORM_line_strp reads from the .debug_line_str section, but
previously the out-of-bounds error reported the .debug_line section.

This incorrect error message showed up when debugging an issue with
some invalid DWARF5 data.

The verify_string.s test has now been extended to check this (which
required a small change to the DWARF verifier to also look at
DW_FORM_line_strp).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146539

Files:
  llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/test/tools/llvm-dwarfdump/X86/verify_strings.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146539.507014.patch
Type: text/x-patch
Size: 5618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230321/af8ae1d3/attachment.bin>