[PATCH] D146512: [TLI] SimplifySetCC - Fold ~X s>/u< ~Y --> Y s>/u< X

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 08:23:32 PDT 2023


RKSimon added a comment.

What regressions are you seeing for ULE vector cases with this fold? Manual optimization looks OK - https://llvm.godbolt.org/z/n9ezae5En



================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:4985
+  if ((isSignedIntSetCC(Cond) || isUnsignedIntSetCC(Cond)) &&
+      N0.getValueType().isInteger()) {
+    if (isBitwiseNot(N0)) {
----------------
N0.getValueType().isInteger() should be implied from the CodeCode - I don't think you need it but make it an assert if you're worried


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146512/new/

https://reviews.llvm.org/D146512



More information about the llvm-commits mailing list