[PATCH] D146511: Precommit test for #61120

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Please can you add remaining icmp predicates - I think we still need sge/uge/eq/ne?



================
Comment at: llvm/test/CodeGen/X86/setcc-combine.ll:503
+
+define i64 @cmp_sgt(i64 %a, i64 %b) {
+; CHECK-LABEL: cmp_sgt:
----------------
maybe rename these to @cmp_not_????? to better explain the test


================
Comment at: llvm/test/CodeGen/X86/setcc-combine.ll:584
+  ret i64 %r
+}
+
----------------
Please can you add at least one test with the constant on the LHS, to check that existing canonicalization will commute it.


================
Comment at: llvm/test/CodeGen/X86/setcc-combine.ll:640
+
+define <2 x i64> @cmp_sle_vec(<2 x i64> %a, <2 x i64> %b) {
+; CHECK-LABEL: cmp_sle_vec:
----------------
<2 x i64> are interesting due to the weak support pre-SSE4 but it'd be good have some other vector types as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146511/new/

https://reviews.llvm.org/D146511