[PATCH] D137091: [llvm-readobj] Rename JSON Flag fields to be more consistent

Tue Mar 21 05:38:33 PDT 2023

jhenderson added a comment.

In D137091#4209313 <https://reviews.llvm.org/D137091#4209313>, @hans wrote:

> This broke some Chromium builds: https://bugs.chromium.org/p/chromium/issues/detail?id=1426287
>
> It turns out we have a tool that consumes this JSON. Maybe that one can be made to accept the encoding both before and after this change, but there may be others.
>
> That raises the question of what the compatibility story is here. Are we okay with breaking all consumers of this JSON?

@paulkirth will be better placed to discuss this, but it's worth noting that a significant amount of the JSON output prior to @paulkirth's work was fundamentally broken. I think it makes a degree of sense to make other changes like this that aren't necessarily required for compatibility, whilst everything else is being overhauled. Longer-term, I do believe we should aim for compatibility, unless there's a good reason to break it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137091/new/

https://reviews.llvm.org/D137091