[PATCH] D146423: [Analys] Added new context analys for BB/Inst

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 05:38:17 PDT 2023


mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ContextAnalysis.cpp:13-14
+
+static std::string ConcatWithDelimeter(std::string Base, std::string Attaching,
+                                       std::string Delimeter = "_") {
+  if (Base == "")
----------------
StringRef (here and everywhere)


================
Comment at: llvm/lib/Analysis/ContextAnalysis.cpp:15
+                                       std::string Delimeter = "_") {
+  if (Base == "")
+    return Attaching;
----------------
`.empty()` (here and everywhere)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146423/new/

https://reviews.llvm.org/D146423



More information about the llvm-commits mailing list