[PATCH] D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-dwarfdump/ARM/aligned_line_tables.s:18
+// L4: 0000002b N .Ltable0_end
+// MULT4-NOT: warning:
+// MULT4: Address            Line   Column File   ISA Discriminator Flags
----------------
So, in case it wasn't clear, this will only check that there is no warning between the two CHECK lines that are used either side of it. If you want to check that no warning appears in the output at all, you're better off adding `--implicit-check-not='warning:'` to the FileCheck command-line.


================
Comment at: llvm/test/tools/llvm-dwarfdump/ARM/aligned_line_tables.s:19
+// MULT4-NOT: warning:
+// MULT4: Address            Line   Column File   ISA Discriminator Flags
+// MULT4-NEXT: ------------------ ------ ------ ------ --- ------------- -------------
----------------
Not required, but as FileCheck by default doesn't treat whitespace as significant, when I have a line like this followed by -NEXT lines, I add a few extra spaces between the end of the CHECK and the actual to-be-matched data, so that everything lines up. In this case, I'd do:
```
// MULT4:      Address            Line   Column File   ISA Discriminator Flags
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143513/new/

https://reviews.llvm.org/D143513