[PATCH] D145923: [MCContext] Use `const Twine &` in symbol creation methods. NFC

Junchang Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 21:20:21 PDT 2023


paperchalice added a comment.

I recently worked on an assembler which allow user add prefix or set values to symbols, `getOrCreateSymbol` can create symbols with prefix in `Twine`, but if I want to set the value for the symbol with prefix, `setSymbolValue` no longer works because it expect `StringRef` rather than `Twine` like `getOrCreateSymbol`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145923/new/

https://reviews.llvm.org/D145923



More information about the llvm-commits mailing list