[PATCH] D146169: Non-debuginfo JITLink perf jitdump support

Mon Mar 20 18:43:18 PDT 2023

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

In D146169#4205438 <https://reviews.llvm.org/D146169#4205438>, @pchintalapudi wrote:

>> Do the perf JIT APIs support unloading code? If so these should have a // TODO to fill them in later. (I don't think they're needed for the initial commit).
>
> I don't see any records for code unloading in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/Documentation/jitdump-specification.txt , and PerfJITEventListener didn't have support for code unloading either, so I'm inclined to believe it doesn't exist right now.

Thanks for checking, and for addressing all the review feedback. LGTM!

I really appreciate your work on this -- it's very exciting to see profiling support making its way into ORC. Thanks Prem!

- Lang.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146169/new/

https://reviews.llvm.org/D146169