[PATCH] D42600: [CodeGen][Shrink-wrap]split restore point

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: llvm/lib/CodeGen/ShrinkWrap.cpp:884-885
+    return false;
+  if (!ArePointsInteresting())
+    return false;
 
----------------
nickdesaulniers wrote:
> should we still return `false` here if if `Changed == true`?
> 
> Am I reading this right? Did the previous version of `ShrinkWrap::runOnMachineFunction` never return `true`?
Correct, the previous version doesn't change the code, it just tells `PrologEpilogInserter` where to place the prologue/epilogue through `MachineFrameInfo`.

I guess here we should return true if we do any edge-splitting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42600/new/

https://reviews.llvm.org/D42600