[PATCH] D146257: Restore code size tracking support in Darwin

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 15:05:13 PDT 2023


paquette updated this revision to Diff 506741.
paquette retitled this revision from "Consume "size_text" instead of size..text or size.__text" to "Restore code size tracking support in Darwin".
paquette edited the summary of this revision.
paquette added a comment.

Address review feedback


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146257/new/

https://reviews.llvm.org/D146257

Files:
  lnt/tests/test_suite.py


Index: lnt/tests/test_suite.py
===================================================================
--- lnt/tests/test_suite.py
+++ lnt/tests/test_suite.py
@@ -80,7 +80,7 @@
             fail;*;*;*;
         {%- else -%}
             pass;{{ test.metrics.compile_time if test.metrics }};\
-{{ test.metrics['size..text'] if test.metrics }};\
+{{ test.metrics.get('size..text') or test.metrics.get('size.__text') if test.metrics }};\
 {{ test.metrics.hash if test.metrics }};
         {%- endif -%}
         {%- if test.code == "FAIL" or test.code == "NOEXE" -%}
@@ -714,6 +714,8 @@
             'hash': 'hash',
             'link_time': 'compile',
             'size..text': 'code_size',
+            # On Darwin, the section name is reported as `__text`.
+            'size.__text': 'code_size',
             'mem_bytes': 'mem',
             'link_mem_bytes': 'mem'
         }
@@ -724,6 +726,8 @@
             'hash': str,
             'link_time': float,
             'size..text': float,
+            # On Darwin, the section name is reported as `__text`.
+            'size.__text': float,
             'mem_bytes': float,
             'link_mem_bytes': float
         }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146257.506741.patch
Type: text/x-patch
Size: 1173 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230320/6264e231/attachment.bin>


More information about the llvm-commits mailing list