[PATCH] D146394: [NFC] Replace strlen with StringRef::size

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 14:18:30 PDT 2023


vitalybuka added a subscriber: hans.
vitalybuka added inline comments.


================
Comment at: llvm/lib/Option/Option.cpp:208
     // Matches iff this is an exact match.
-    // FIXME: Avoid strlen.
-    if (ArgSize != strlen(Args.getArgString(Index)))
----------------
@hans do  you know what this TODO is about, https://reviews.llvm.org/D1387
If this is about performance, we still have strlen in StringRef



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146394/new/

https://reviews.llvm.org/D146394



More information about the llvm-commits mailing list