[PATCH] D146351: sanitizer_common: Use plain thread_local for __sancov_lowest_stack definition.

Mon Mar 20 12:19:58 PDT 2023

yln added a reviewer: thetruestblue.
yln added a subscriber: thetruestblue.
yln added a comment.
This revision now requires review to proceed.

Hi, thanks Vitaly!

AFAIR, `thread_local` (and TLS in general) require macOS 10.12 / iOS 10 / watchOS 3 or greater.

Therefore, can we hold off on this a bit?

@thetruestblue is looking into bumping the minimal sanitizer deployment targets for Apple platforms.  Blue, when you do that, can you circle back here and apply this patch?  This change is a good example for a sanity check: it doesn't work right now but should work afterwards.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146351/new/

https://reviews.llvm.org/D146351