[PATCH] D145224: [LLVM][OHOS] Use emulated TLS for OHOS platform

Mon Mar 20 09:16:26 PDT 2023

jrtc27 added inline comments.

================
Comment at: llvm/test/CodeGen/RISCV/emutls.ll:1
+; RUN: llc < %s -emulated-tls -mtriple=riscv64-linux-gnu | FileCheck -check-prefix=RISCV64 %s
+; RUN: llc < %s -emulated-tls -mtriple=riscv64-linux-ohos | FileCheck -check-prefix=RISCV64 %s
----------------
kpdev42 wrote:
> jrtc27 wrote:
> > NACK for this test, just add your RUN lines to the one in the patch that adds emutls support to RISC-V.
> Excuse me, do you mean that it is better to prepare a separate patch for RISC-V, right?
D143708 adds emulated TLS support (which I assume is what you're using, since this patch doesn't modify the backend to support it) and includes a test for that. You are not adding emulated TLS support here, you're just changing a default, so you shouldn't be writing your own (worse) test for emulated TLS code generation, you should just be adding RUN lines to the test in the patch you're basing this on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145224/new/

https://reviews.llvm.org/D145224