[compiler-rt] b33437c - Reland "[LSAN][HWASAN] Turn on leak sanitizer in HWASAN for Linux"

Kirill Stoimenov via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 08:42:26 PDT 2023


Author: Kirill Stoimenov
Date: 2023-03-20T15:41:05Z
New Revision: b33437c969f3bc45576fda4bf43872aea8f7e8c6

URL: https://github.com/llvm/llvm-project/commit/b33437c969f3bc45576fda4bf43872aea8f7e8c6
DIFF: https://github.com/llvm/llvm-project/commit/b33437c969f3bc45576fda4bf43872aea8f7e8c6.diff

LOG: Reland "[LSAN][HWASAN] Turn on leak sanitizer in HWASAN for Linux"

This reverts commit 35c05f04e547100d03b6359d1f66950ff83350e0.

Added: 
    

Modified: 
    compiler-rt/lib/hwasan/hwasan.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/hwasan/hwasan.cpp b/compiler-rt/lib/hwasan/hwasan.cpp
index 662cfb4e9f807..0a5999cf7f2a5 100644
--- a/compiler-rt/lib/hwasan/hwasan.cpp
+++ b/compiler-rt/lib/hwasan/hwasan.cpp
@@ -86,8 +86,9 @@ static void InitializeFlags() {
     cf.clear_shadow_mmap_threshold = 4096 * (SANITIZER_ANDROID ? 2 : 8);
     // Sigtrap is used in error reporting.
     cf.handle_sigtrap = kHandleSignalExclusive;
-    // FIXME: enable once all false positives have been fixed.
-    cf.detect_leaks = false;
+    // For now only tested on Linux. Other plantforms can be turned on as they
+    // become ready.
+    cf.detect_leaks = cf.detect_leaks && SANITIZER_LINUX && !SANITIZER_ANDROID;
 
 #if SANITIZER_ANDROID
     // Let platform handle other signals. It is better at reporting them then we


        


More information about the llvm-commits mailing list