[PATCH] D137707: Move "auto-init" instructions to the dominator of their users

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/MoveAutoInit.cpp:93
+    // The remaining logic should be pretty similar.
+    if (!hasAutoInitMetadata(I))
+      continue;
----------------
nikic wrote:
> Assert or check that use_empty(), the transform relies on it.
> 
> I'd also assert or check that the instruction is not volatile. (Not sure if auto-init can be volatile...)
> Assert or check that use_empty(), the transform relies on it
I'm not quite sure which use you're referring to, can you explain?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137707/new/

https://reviews.llvm.org/D137707