[PATCH] D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

This is going to need review by somebody with memtag experience still.

Meanwhile, I think some test cases are needed for a few of the warnings.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5908
+    if (auto E = Contents.takeError()) {
+      reportUniqueWarning("couldn't get SHT_AARCH64_MEMTAG_GLOBALS_DYNAMIC section contents: " + toString(std::move(E)));
+      return ArrayRef<uint8_t>();
----------------
I don't think this is tested?


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5973
+    if (Error) {
+        reportUniqueWarning("error decoding SHT_AARCH64_MEMTAG_GLOBALS_DYNAMIC: " + Twine(Error));
+        GlobalDescriptors.clear();
----------------
Test case?


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5985
+      if (Error) {
+        reportUniqueWarning("error decoding SHT_AARCH64_MEMTAG_GLOBALS_DYNAMIC: " + Twine(Error));
+        GlobalDescriptors.clear();
----------------
Test case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145761/new/

https://reviews.llvm.org/D145761