[PATCH] D146391: Add DWARFContext generation from LinkGraphs, use in perf support

Prem Chintalapudi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 01:12:33 PDT 2023


pchintalapudi added a comment.

For testing, there are a couple of options that I think should be possible.

Right now D146169 <https://reviews.llvm.org/D146169>'s test is only that the jitdump file exists, not on the accuracy of the content. I've been verifying the content of that file using my own custom python script, so one option is to upload that script (to where?), output to json, and check that json for accuracy (with what tools?).

Another option is to take advantage of the cross-process support and replace the default called addresses in the plugin with calls to verification functions. This would probably take the form of a new cpp unit test (don't know how to do this) and has the advantage of being able to test the state on structured data rather than reading a binary file that's sensitive to bugs in the writer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146391/new/

https://reviews.llvm.org/D146391



More information about the llvm-commits mailing list