[PATCH] D144351: llvm-tblgen: Let each emitter self-contained

Sun Mar 19 21:33:33 PDT 2023

myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM Cheers

In D144351#4152342 <https://reviews.llvm.org/D144351#4152342>, @chapuni wrote:

> In D144351#4148987 <https://reviews.llvm.org/D144351#4148987>, @myhsu wrote:
>
>> then yeah, moving it to public header might be a good idea.
>
> I'm afraid if it would affect other *-tblgen. It was in public in my prototype.
> I'd be happy to move it to public step-by-step.
>
> When we could implement tblgen plugin, I wonder;
>
> - If we took `-load foo-pluigin.so`, how it could be activated. I guess we should enhance `TableGen::Emitter::Opt` to activate myself. In my current implementation, `TableGen::Emitter::Opt` just registers an option.

IMHO activation upon the plugin is loaded makes more sense, because unlike the legacy PassManager, there won't be multiple TG actions in a single invocation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144351/new/

https://reviews.llvm.org/D144351