[PATCH] D145516: [Inliner] Avoid excessive inlining through devirtualised calls

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 19 15:24:09 PDT 2023


aeubanks added a comment.

sorry for the slow response

looking at the test case, this looks more like an issue with inlining heuristics. the `branch_weights` says that we almost never call `longname` in `rec_call_to_longname` but we still end up inlining it, presumably due to the devirtualization bonus as you've said? removing the `!prof` from the branch makes this test case ok which is odd


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145516/new/

https://reviews.llvm.org/D145516



More information about the llvm-commits mailing list