[PATCH] D146251: [test-suite] Fix FreeBSD and OpenBSD builds
Brad Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 18 16:49:02 PDT 2023
brad added a comment.
In D146251#4204317 <https://reviews.llvm.org/D146251#4204317>, @dim wrote:
> Yes, <tgmath.h> is also available on macOS, but it is unnecessary, even on Linux. Using just <math.h> should be sufficient, because the only math function used is `hypot(3)` which works on doubles by default. There is really no need to pull in the tricky macro machinery from tgmath here.
I was thinking about just using math.h as well but wasn't sure what OS's might be intended to be supported. I started looking through commit history and wasn't sure why tgmath.h was used in the first place.
Repository:
rT test-suite
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146251/new/
https://reviews.llvm.org/D146251
More information about the llvm-commits
mailing list