[PATCH] D146346: [InstCombine] Add tests for indirect mul by power of 2; NFC
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 18 04:55:23 PDT 2023
nikic added inline comments.
================
Comment at: llvm/test/Transforms/InstCombine/mul-pow2.ll:63
+ ret <2 x i8> %r
+}
----------------
Missing a commuted test -- everything here gets canonicalized to ` mul s, x`.
Also missing a multi-use test. This is going to fail (as in, perform an unprofitable transform) due to open FIXMEs in takeLog2(), but we should at least highlight that the problem exists.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146346/new/
https://reviews.llvm.org/D146346
More information about the llvm-commits
mailing list