[PATCH] D146274: [LICM] Do not hoist widenable conditions

[Artur Pilipenko via Phabricator via llvm-commits]

apilipenko accepted this revision.
apilipenko added a comment.
This revision is now accepted and ready to land.

Looks good to me. I don't think we had a specific motivation in mind for that change. And now we know a clear reason not to LICM widenable conditions.



================
Comment at: llvm/test/Transforms/LICM/explicit_guards.ll:9
+; Widenable conditions don't actually alias anything or throw, however
+; hoisting them is not profitable. If we want to widen guards in branch
+; form, we need to generate them at the point of widenable_condition call
----------------
; Widenable conditions don't actually alias anything or throw, however
; hoisting them is not profitable because it may prevent guard widening in the loop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146274/new/

https://reviews.llvm.org/D146274