[PATCH] D146257: Consume "size_text" instead of size..text or size.__text

[Azharuddin Mohammed via Phabricator via llvm-commits]

azharudd added inline comments.


================
Comment at: lnt/tests/test_suite.py:83
             pass;{{ test.metrics.compile_time if test.metrics }};\
-{{ test.metrics['size..text'] if test.metrics }};\
 {{ test.metrics.hash if test.metrics }};
----------------
In light of the comment below, this could become:

```
{{ test.metrics['size..text'] or test.metrics['size.__text'] if test.metrics }};\
```

or, better yet
```
{{ test.metrics.get('size..text') or test.metrics.get('size.__text') if test.metrics }};\
```


================
Comment at: lnt/tests/test_suite.py:716
             'link_time': 'compile',
-            'size..text': 'code_size',
             'mem_bytes': 'mem',
----------------
Wouldn't it be a more clear/straightforward solution to just add another line here for `'size.__text'` (similar to what we are doing for `mem` right below)?

```
'size..text': 'code_size',
# On Darwin, the section name is reported as `__text`.
'size.__text': 'code_size',
```

Only one of `'size..text'` or `'size.__text'` would exist in the lit output, and whichever exists would correspond to the `'code_size'`.  This way, we would also not need https://reviews.llvm.org/D146260, and the lit output will continue to have the  exact section name. 


================
Comment at: lnt/tests/test_suite.py:726
             'link_time': float,
-            'size..text': float,
             'mem_bytes': float,
----------------
and another corresponding `'size.__text': float,` line right below this too. 


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146257/new/

https://reviews.llvm.org/D146257