[PATCH] D139336: [IRSim] Ensure that assignment accurately reduces potential mapping between different candidates

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

I think this looks good, with a nit.



================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:789
+    else if (ValueMappingIt->second.size() != 1) {
+      for (unsigned OtherVal : ValueMappingIt->second) {
+        if (OtherVal == InstValB)
----------------
would it be possible to pull this out into a lambda/function?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139336/new/

https://reviews.llvm.org/D139336