[PATCH] D146267: [llvm] Handle duplicate call bases when applying branch funneling

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 10:01:21 PDT 2023


tejohnson added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1397
 
+      if (!CB.getParent()) {
+        // When finding devirtualizable calls, it's possible to find the same
----------------
I don't think this is safe since when we eraseFromParent the instruction is deleted. Can we track a different way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146267/new/

https://reviews.llvm.org/D146267



More information about the llvm-commits mailing list