[PATCH] D143018: [DAGCombiner][NFC] Factor out ByteProvider

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 09:46:21 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/include/llvm/ADT/ByteProvider.h:53
+private:
+  ByteProvider<T>(std::optional<T> Src, unsigned DestOffset, unsigned SrcOffset)
+      : Src(Src), DestOffset(DestOffset), SrcOffset(SrcOffset) {}
----------------
probably should use int64_t offsets?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143018/new/

https://reviews.llvm.org/D143018



More information about the llvm-commits mailing list