[PATCH] D145586: [AMDGPU] Tweak PromoteAlloca limits

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Unrelated but PromoteAllocaToVectorLimit  should really move to a new PM pass parameter



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:402
 
-  // Use up to 1/4 of available register budget for vectorization.
+  // Use up to 1/2 of available register budget for vectorization if we have
+  // >=64 MaxVGPRs, otherwise use 1/4.
----------------
Half feels pretty aggressive


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:405-406
+  // If PromoteAllocaToVectorLimit is used, also use 1/4.
   unsigned Limit = PromoteAllocaToVectorLimit ? PromoteAllocaToVectorLimit * 8
                                               : (MaxVGPRs * 32);
+  const unsigned SizeFactor =
----------------
The largest register class we support is <32 x i32>, do we definitely never introduce larger vectors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145586/new/

https://reviews.llvm.org/D145586