[PATCH] D142796: Flang semantic check support for tile and unroll OpenMP Directive.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.
Herald added a subscriber: jplehr.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:424-425
+    CheckTileConstruct(x);
+  }
+  if (beginDir.v == llvm::omp::Directive::OMPD_unroll) {
+    CheckUnrollConstruct(x);
----------------
I don't think the directive can be tile and unroll at the same time.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:630
       if (const auto v{GetIntValue(orderedClause->v)}) {
+
         orderedLevel = *v;
----------------
Remove


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142796/new/

https://reviews.llvm.org/D142796