[PATCH] D146233: [LICM] Don't promote store to global even in single-thread mode

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 08:27:53 PDT 2023


nikic added a comment.

In D146233#4200982 <https://reviews.llvm.org/D146233#4200982>, @efriedma wrote:

> Is the issue here actually specific to global variables?  I mean, you can't mark a local variable noalias, but noalias/TBAA metadata can apply to local variables.

There is also an issue with AA metadata, but I think it's a bit different from this one, see https://github.com/llvm/llvm-project/issues/60860#issuecomment-1474006326. In addition to that, we also currently preserve AA metadata on the promoted loads and stores in some cases where it isn't legal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146233/new/

https://reviews.llvm.org/D146233



More information about the llvm-commits mailing list