[PATCH] D146271: [Webassembly][multivalue] select correct libcall signature when multivalue feature enabled

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

For the description, here's some possible clearer wording:

  Update libcall signatures to use multivalue return rather than returning via a pointer when the multivalue features is enabled in the WebAssembly backend. 

We also still don't have a stable C calling convention that uses multivalue, so this doesn't seem entirely future-proof, but maybe that's ok.



================
Comment at: llvm/docs/ReleaseNotes.rst:145
 
-* ...
+* Select correct libcall signature when multivalue feature enabled.
 
----------------
We don't typically add release notes for bug fixes like this (although maybe we should?)


================
Comment at: llvm/test/CodeGen/WebAssembly/multivalue_libcall.ll:1
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -mcpu=mvp -mattr=+multivalue | FileCheck %s --check-prefix=MULTIVALUE
+; RUN: llc < %s -asm-verbose=false -verify-machineinstrs -mcpu=mvp | FileCheck %s --check-prefix=NO_MULTIVALUE
----------------
It would be good to use the utils/update_llc_test_checks.py script to automatically produce the test output.


================
Comment at: llvm/test/CodeGen/WebAssembly/multivalue_libcall.ll:4
+
+; Test that the multivalue for libcall
+
----------------
Incomplete sentence?


================
Comment at: llvm/test/CodeGen/WebAssembly/multivalue_libcall.ll:21-24
+; CHECK: 	local.get	0
+; CHECK: 	local.get	1
+; CHECK: 	local.get	2
+; CHECK: 	local.get	3
----------------
I don't think the `CHECK` lines are actually being checked because FileCheck is only run with MULTIVALUE and NO_MULTIVALUE prefixes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146271/new/

https://reviews.llvm.org/D146271