[PATCH] D146198: [RISCV] Make ResourceCycles relevant to LMUL

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 07:51:56 PDT 2023


michaelmaitland added a comment.

> If there are some microarchitectures that can't be modeled, just add a new subroutine to upstream if approved.

Does this mean that subtarget routines must be added to the RISCVScheduleV file since the following function needs to know about the custom subroutine to do its isa checks:

  // Helper class for generating a list of resource cycles of different LMULs.
  class ResourceCycles<list<ResourceCycle> resourceCycles, string mx> {

I am concerned that the `RISCVScheduleV` file will take on bloat due to holding subtarget related routines if this is the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146198/new/

https://reviews.llvm.org/D146198



More information about the llvm-commits mailing list