[PATCH] D146136: [llvm][CycleInfo] Quick look-up for block in cycle.

Fri Mar 17 02:29:27 PDT 2023

foad added a comment.

In D146136#4201439 <https://reviews.llvm.org/D146136#4201439>, @sameerds wrote:

> In D146136#4201388 <https://reviews.llvm.org/D146136#4201388>, @foad wrote:
>
>> Patch seems fine to me, but I wonder if we need to get more eyes on your SetVector changes. I don't think there is a code owner for ADT. @dblaikie?
>
> One good thing is that this not change the way SetVector is currently used. If all the user wants is a vector and a set of the same type, then nothing changed for them. But it does allow a new use-case by giving enough rope. It's difficult to specify static constraints. Can a user have a vector of float and a set of float? Sure they can, as long as they understand the lossy hashing produced by silently converting the float to int when inserting in the set!

My only very slight unease was about which methods of SetVector should take key_type and which should take value_type. Is it obvious in all cases? Is there a precedent in STL (or Boost) to guide us?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146136/new/

https://reviews.llvm.org/D146136