[PATCH] D145379: [FuncSpec] Cost model improvements.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 02:01:11 PDT 2023


SjoerdMeijer added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/FunctionSpecialization.h:51
+// To compute the codesize increase, we first estimate the initial codesize of
+// the function as [number of instructions] + [number of inline candidates] x
+// [small function size]. The "small function size" corresponds to the minimum
----------------
Thanks for adding these descriptions, that is very helpful.

Just trying to understand the initial code size calculation better, the last part:

   [number of inline candidates] x [small function size]

why is that not the [number of instructions] for each inline candidate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145379/new/

https://reviews.llvm.org/D145379



More information about the llvm-commits mailing list