[PATCH] D146238: [StandardInstrumentations] Check that module analyses are properly invalidated

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1204
+      }
+    }
   });
----------------
aeubanks wrote:
> nikic wrote:
> > Hm, does that mean that in most cases we're going to verify both all functions via the function hash, and then again using the module hash (which includes all function hashes)?
> yes, but that's fine, it's only doubling this work (which shouldn't matter in expensive checks builds)
> 
> we could have the module analysis fetch the hash of each function via the function hash analysis, but at that point we start mixing module and function analyses which I'd like to avoid to keep this conceptually simple and not fall into traps with cross-level analyses (and it would require changes of how we hash modules by combining function hashes rather than hashing everything one after the other, but that's not too much work)
Okay, let's keep it simple for now...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146238/new/

https://reviews.llvm.org/D146238