[PATCH] D146205: [test][MemDep] Correct the 'NOT' checks in the invalidation.ll test case. NFC

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 01:33:54 PDT 2023


This revision was automatically updated to reflect the committed changes.
Closed by commit rGfed4e7d0d2a4: [test][MemDep] Correct the 'NOT' checks in the invalidation.ll test case. NFC (authored by bjope).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146205/new/

https://reviews.llvm.org/D146205

Files:
  llvm/test/Analysis/MemoryDependenceAnalysis/invalidation.ll


Index: llvm/test/Analysis/MemoryDependenceAnalysis/invalidation.ll
===================================================================
--- llvm/test/Analysis/MemoryDependenceAnalysis/invalidation.ll
+++ llvm/test/Analysis/MemoryDependenceAnalysis/invalidation.ll
@@ -1,16 +1,19 @@
 ; Test that memdep gets invalidated when the analyses it depends on are
 ; invalidated.
 ;
-; Check AA. AA is stateless, there's nothing to invalidate.
+; Check AA. AA is stateless, but given an explicit invalidate (abandon) the
+; AAManager is invalidated and we must invalidate memdep as well given
+; the transitive dependency.
 ; RUN: opt -disable-output -debug-pass-manager -aa-pipeline='basic-aa' %s 2>&1 \
 ; RUN:     -passes='require<memdep>,invalidate<aa>,gvn' \
 ; RUN:     | FileCheck %s --check-prefix=CHECK-AA-INVALIDATE
 ; CHECK-AA-INVALIDATE: Running pass: RequireAnalysisPass
 ; CHECK-AA-INVALIDATE: Running analysis: MemoryDependenceAnalysis
 ; CHECK-AA-INVALIDATE: Running pass: InvalidateAnalysisPass
-; CHECK-NOT-AA-INVALIDATE: Invalidating analysis: MemoryDependenceAnalysis
-; CHECK-AA-INVALIDATE: Running pass: GVN
-; CHECK-NOT-AA-INVALIDATE: Running analysis: MemoryDependenceAnalysis
+; CHECK-AA-INVALIDATE: Invalidating analysis: AAManager
+; CHECK-AA-INVALIDATE: Invalidating analysis: MemoryDependenceAnalysis
+; CHECK-AA-INVALIDATE: Running pass: GVNPass
+; CHECK-AA-INVALIDATE: Running analysis: MemoryDependenceAnalysis
 ;
 ; Check domtree specifically.
 ; RUN: opt -disable-output -debug-pass-manager %s 2>&1 \
@@ -21,7 +24,7 @@
 ; CHECK-DT-INVALIDATE: Running pass: InvalidateAnalysisPass
 ; CHECK-DT-INVALIDATE: Invalidating analysis: DominatorTreeAnalysis
 ; CHECK-DT-INVALIDATE: Invalidating analysis: MemoryDependenceAnalysis
-; CHECK-DT-INVALIDATE: Running pass: GVN
+; CHECK-DT-INVALIDATE: Running pass: GVNPass
 ; CHECK-DT-INVALIDATE: Running analysis: MemoryDependenceAnalysis
 ;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146205.506005.patch
Type: text/x-patch
Size: 1905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230317/6781a2c0/attachment.bin>


More information about the llvm-commits mailing list