[PATCH] D137088: [llvm-readobj] Standardize JSON output for `Other` field

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, but one suggestion.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:7686
+template <class ELFT>
+void JSONELFDumper<ELFT>::printZeroSymbolOtherField(
+    const Elf_Sym &Symbol) const {
----------------
It might be worth a comment explaining why for JSON it's desirable to do things differently here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137088/new/

https://reviews.llvm.org/D137088