[PATCH] D137096: [llvm-readobj] Provide Hash Histogram for all ELFDumper implementations

Fri Mar 17 01:10:56 PDT 2023

jhenderson added inline comments.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:4972
+                                                 ArrayRef<size_t> Count,
+                                                 bool IsGnu) const {
   size_t CumulativeNonZero = 0;
----------------
paulkirth wrote:
> jhenderson wrote:
> > I have a marginal preference to make this argument `StringRef TableDescription` (with values of "" and `.gnu.hash' respectively, since there's only one place the behaviour is different between the two output styles, as far as I can tell.
> Sure, but if they have the same interface, then they can be overrides from the base class, as they are now. 
Okay, that's fair.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137096/new/

https://reviews.llvm.org/D137096