[PATCH] D146274: [LICM] Do not hoist widenable conditions

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1232
 
     if (match(CI, m_Intrinsic<Intrinsic::experimental_widenable_condition>()))
+      // Widenable conditions don't actually alias anything or throw, however
----------------
skatkov wrote:
> why don't you want just to remove this match?
> In my understanding by default LICM will touch it...
> 
> @apilipenko, this match has been added at https://reviews.llvm.org/D69907. Do you know any specific motivation to  allow hoisting of widenable condition intrinsic? May be anything is missing?
I want to keep the comment in anyways.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146274/new/

https://reviews.llvm.org/D146274