[PATCH] D146274: [LICM] Do not hoist widenable conditions

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added reviewers: apilipenko, reames.
skatkov added a subscriber: apilipenko.
skatkov added a comment.

The change itself looks reasonable.

However it would be interesting to know the motivation this check has been added.



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1232
 
     if (match(CI, m_Intrinsic<Intrinsic::experimental_widenable_condition>()))
+      // Widenable conditions don't actually alias anything or throw, however
----------------
why don't you want just to remove this match?
In my understanding by default LICM will touch it...

@apilipenko, this match has been added at https://reviews.llvm.org/D69907. Do you know any specific motivation to  allow hoisting of widenable condition intrinsic? May be anything is missing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146274/new/

https://reviews.llvm.org/D146274