[PATCH] D145846: [InstCombine] enhance icmp with sub folds
Allen zhong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 16 19:38:05 PDT 2023
Allen added a comment.
In D145846#4200141 <https://reviews.llvm.org/D145846#4200141>, @goldstein.w.n wrote:
>> The new IR with and removes a use of the input variable, which is better for analysis.
>
> "and" -> `And` (otherwise it looks like the conjugation, not the operator.
Done, thanks
================
Comment at: llvm/test/Transforms/InstCombine/icmp-sub.ll:564
}
+
+; https://alive2.llvm.org/ce/z/D2Aph4
----------------
goldstein.w.n wrote:
> Can you split the tests into two commits so we can see the diff from the patch?
Done, I Precommit the test with D146268
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145846/new/
https://reviews.llvm.org/D145846
More information about the llvm-commits
mailing list