[compiler-rt] 35c05f0 - Revert "[LSAN][HWASAN] Turn on leak sanitizer in HWASAN for Linux"

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 19:17:49 PDT 2023


Author: Vitaly Buka
Date: 2023-03-16T19:16:16-07:00
New Revision: 35c05f04e547100d03b6359d1f66950ff83350e0

URL: https://github.com/llvm/llvm-project/commit/35c05f04e547100d03b6359d1f66950ff83350e0
DIFF: https://github.com/llvm/llvm-project/commit/35c05f04e547100d03b6359d1f66950ff83350e0.diff

LOG: Revert "[LSAN][HWASAN] Turn on leak sanitizer in HWASAN for Linux"

Breaks x86_64 qemu tests.

This reverts commit 6c756486d44914bac6fb20513b8c41f1a5726c4c.

Added: 
    

Modified: 
    compiler-rt/lib/hwasan/hwasan.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/hwasan/hwasan.cpp b/compiler-rt/lib/hwasan/hwasan.cpp
index 0a5999cf7f2a5..662cfb4e9f807 100644
--- a/compiler-rt/lib/hwasan/hwasan.cpp
+++ b/compiler-rt/lib/hwasan/hwasan.cpp
@@ -86,9 +86,8 @@ static void InitializeFlags() {
     cf.clear_shadow_mmap_threshold = 4096 * (SANITIZER_ANDROID ? 2 : 8);
     // Sigtrap is used in error reporting.
     cf.handle_sigtrap = kHandleSignalExclusive;
-    // For now only tested on Linux. Other plantforms can be turned on as they
-    // become ready.
-    cf.detect_leaks = cf.detect_leaks && SANITIZER_LINUX && !SANITIZER_ANDROID;
+    // FIXME: enable once all false positives have been fixed.
+    cf.detect_leaks = false;
 
 #if SANITIZER_ANDROID
     // Let platform handle other signals. It is better at reporting them then we


        


More information about the llvm-commits mailing list