[PATCH] D146266: gn build: Fix Android build.

Thu Mar 16 18:10:38 PDT 2023

srhines added a comment.

In D146266#4200993 <https://reviews.llvm.org/D146266#4200993>, @aeubanks wrote:

> yeah this was very confusing when I was looking at this
>
>   $ fd i386 ~/repos/chromium/src/third_party/android_ndk/toolchains/llvm/prebuilt/
>   /usr/local/google/home/aeubanks/repos/chromium/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/lib64/clang/12.0.5/lib/linux/i386/
>   $ fd i686 ~/repos/chromium/src/third_party/android_ndk/toolchains/llvm/prebuilt/
>   ...
>   /usr/local/google/home/aeubanks/repos/chromium/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/lib64/clang/12.0.5/lib/linux/libclang_rt.ubsan_standalone_cxx-i686-android.a # and lots of other compiler-rt libs
>   /usr/local/google/home/aeubanks/repos/chromium/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/include/i686-linux-android/
>   /usr/local/google/home/aeubanks/repos/chromium/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/i686-linux-android/
>   ...
>
> building with this patch, I still get `ld.lld: error: unable to find library -l:libunwind.a` for all the different arches
>
> perhaps the Android NDK in Chromium is not the standard one? are you using the one bundled in Chromium?

I'm pretty sure that Peter is building/using the toolchain with the Android platform, so it might be picking up NDK parts from the platform build. As for the one in Chromium, I see a "12.0.5" in there, which means that it is quite old. You may want to consider updating that in any case. Even NDK r25 from last year is on ~Clang-14. https://github.com/android/ndk/wiki/Changelog-r25#r25c shows a lot of other nice improvements too in terms of repo size, so that might be a real nice win for Chromium devs.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146266/new/

https://reviews.llvm.org/D146266